-
Notifications
You must be signed in to change notification settings - Fork 90
Added Benchmark Evaluation Framework with CORE Benchmark Suite #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jasmine-Yuting-Zhang
wants to merge
18
commits into
main
Choose a base branch
from
nanochat
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dule under 'external/nanochat'.
- Resolved a RuntimeError caused by non-contiguous tensors during view operations (in nanochat - gpt.py): "view size is not compatible with input tensor's size and stride...". Replaced .view() with .reshape()
- Resolved an issue where the configuration requested 'train_loss' in the results, but the server's get_logged_items() did not include it.
- To avoid vocabulary size mismatch between model and tokenizer during CORE evaluation.
- Updated log message from "global accuracy" to "Average Centered CORE benchmark metric" - Used ruff to format code
…ORE metadata so ty check is clean again.
- Added instructions for initializing submodules and resolving maturin build failure.
✅ Deploy Preview for platodocs canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces comprehensive integration of the Nanochat language model stack into Plato, enabling federated learning experiments with GPT models (e.g, Nanochat). This integration adds Nanochat as a submodule, and adds the CORE benchmark for language model evaluations.
Description
Third-party submodule and model integration:
external/nanochat): Git submodule integration of karpathy/nanochat.plato/models/nanochat.py): Nanochat model with configurable architecture parameters, checkpoint loading, and automatic tokenizer attachment.plato/models/registry.py): Registered "Nanochat" model type for seamless configuration-based instantiation.Tokenizer and data processing:
plato/processors/nanochat_tokenizer.py): Wrapper for rustbpe + tiktoken stack with special token support and corpus training capabilities.plato/datasources/nanochat.py): Configurable datasource supporting both real parquet data and synthetic token generation with automatic fallback.plato/datasources/registry.py): "Nanochat" datasource registered for TOML configuration.Training infrastructure:
plato/trainers/nanochat.py): Specialized trainer with Nanochat-specific data loading, training steps, and optimizer strategies.Evaluation framework:
plato/evaluators/nanochat_core.py): Complete port ofnanochat/core_eval.pywith automatic bundle download, task loading, and metric computation.Configuration and examples:
plato/configs/Nanochat/): Ready-to-use synthetic and extended evaluation configurations.plato/examples/nanochat/): Documentation, setup instructions, and quickstart guides.How has this been tested?
Tested CORE benchmark evaluation with configuration file
synthetic_micro.toml.Test execution and results:
Command:
Output showing successful CORE benchmark evaluation on 22 tasks after 1 round of FL training session:
Types of changes
Checklist:
ruff format) and checked using the Ruff linter (ruff check --fix).